git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Move format-patch base commit and prerequisites before email signature

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 9, 2016, 20:51 UTC
Message-ID
<xmqqpoocajbb.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160909200721.xfkbud377ja4wkrt@x>
Josh Triplett <josh@joshtriplett.org> writes:
Show 21 quoted lines
> On Fri, Sep 09, 2016 at 12:41:56PM -0700, Junio C Hamano wrote:
>> So here is a suggested replacement.  I notice that in the MIME case,
>> we do not leave any blank line between the last line of the patch
>> and the baseinfo, which makes it look a bit strange, e.g. output of
>> "format-patch --attach=mimemime -1" may end like this:
>> 
>>     +       test_write_lines 1 2 >expect &&
>>     +       test_cmp expect actual
>>     +'
>>     +
>>      test_expect_success 'format-patch --pretty=mboxrd' '
>>             sp=" " &&
>>             cat >msg <<-INPUT_END &&
>>     base-commit: 6ebdac1bab966b720d776aa43ca188fe378b1f4b
>> 
>>     --------------mimemime--
>> 
>> We may want to tweak it a bit further.
>>  ...
>
> Looks good to me.
Thanks.

Do you mean that the base information that appears immediately after the patch text (either for MIME case or plain-text) does not bother you, though?

Previous: Josh TriplettNext: Josh Triplett
Message 9 of 14 in “Move format-patch base commit and prerequisites before email signature”
  1. Move format-patch base commit and prerequisites before email signatureJosh Triplett, Sep 8, 2016
  2. Junio C HamanoSep 8, 2016
  3. Josh TriplettSep 8, 2016
  4. Junio C HamanoSep 8, 2016
  5. Jeff KingSep 8, 2016
  6. Junio C HamanoSep 8, 2016
  7. Junio C HamanoSep 9, 2016
  8. Josh TriplettSep 9, 2016
  9. Junio C HamanoSep 9, 2016
  10. Josh TriplettSep 9, 2016
  11. Junio C HamanoSep 9, 2016
  12. Junio C HamanoSep 14, 2016
  13. Josh TriplettSep 14, 2016
  14. Junio C HamanoSep 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.