Re: What's cooking in git.git (Nov 2016, #05; Wed, 23)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 29, 2016, 00:06 UTC
Message-ID: <xmqqpolfgndq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <732c0e78-74b5-befa-e3c5-5ed9f221fa3a@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 19 quoted lines

> On 11/23/2016 03:21 PM, Junio C Hamano wrote:
>> * jt/use-trailer-api-in-commands (2016-11-02) 6 commits
>>  - sequencer: use trailer's trailer layout
>>  - trailer: have function to describe trailer layout
>>  - trailer: avoid unnecessary splitting on lines
>>  - commit: make ignore_non_trailer take buf/len
>>  - SQUASH???
>>  - trailer: be stricter in parsing separators
>>
>>  Commands that operate on a log message and add lines to the trailer
>>  blocks, such as "format-patch -s", "cherry-pick (-x|-s)", and
>>  "commit -s", have been taught to use the logic of and share the
>>  code with "git interpret-trailer".
>>
>>  What's the doneness of this topic?
>
> Stefan Beller mentioned [1] that this seemed OK to him from a cursory
> read. Do I need to look for another reviewer (or a more thorough
> review)?

I gave it a cursory review when it was queued, too, so another cursory read does not help very much ;) If I recall correctly, I got an impression that it was reasonably well done.

I haven't had a chance to look at the series again to see if the SQUASH is just the simple matter of squashing it into the one previous, which is the main reason why I haven't decided if it is ready to be in 'next'.

Thanks.