Re: [PATCH 1/1] archive: learn to include submodules in output archive

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2017, 23:18 UTC
Message-ID: <xmqqpohklqa8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZbcLFJPUt3wGsYX-XgAO+xW1ZDGJqN-q=r8i5Zbv_tTw@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 11 quoted lines

> On Mon, Mar 13, 2017 at 3:12 PM, Stefan Beller <sbeller@google.com> wrote:
>
>>> will recursively traverse submodules in the repository and
>>> consider their contents for inclusion in the output archive, subject to
>>> any pathspec filters.
>
> git-archive pays attention to export-ignore and export-subst attribute
> as read from .gitattributes or $GIT_DIR/info/attributes
>
> When recursing into submodules, we'd need to clarify if the attributes
> from the superproject or from the submodules are applied; or both.

I think the most natural expectation is for the output from the "archive --recurse-submodules" command is to be logical concatenation of "archive" run at the top-level and submodules, adjusting the output from the latter with leading paths to the submodules. For that to happen, the attributes that apply to paths inside a submodule must come from that submodule's setting.