Re: [PATCH] Documentation: improve git ls-files -s manpage entry
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 1, 2017, 02:21 UTC
- Message-ID
- <xmqqpogwx3yr.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170331194708.22437-1-mostyn@antipode.se>
Mostyn Bramley-Moore <mostyn@antipode.se> writes:
Show 18 quoted lines
> List the fields in order of appearance in the command output. > > Signed-off-by: Mostyn Bramley-Moore <mostyn@antipode.se> > --- > Documentation/git-ls-files.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt > index 1cab703..a9149fc 100644 > --- a/Documentation/git-ls-files.txt > +++ b/Documentation/git-ls-files.txt > @@ -57,7 +57,8 @@ OPTIONS > > -s:: > --stage:: > - Show staged contents' object name, mode bits and stage number in the output. > + Show staged contents' mode bits, hash, stage number as well as the > + object name in the output.
This is not an improvement, as the word "hash" is merely a colloquial way to say what is officially known as "object name".
If the patch were only to swap "mode bits" and "object name" without doing anything else, it may have been an improvement, though. It is implied that the path the output line talks about is shown, and that is why we do not say "mode bits, object name, stage number and the pathname".
> > --directory:: > If a whole directory is classified as "other", show just its