Re: [PATCH v2] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2017, 06:31 UTC
Message-ID: <xmqqpofi35ik.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170503215015.17949-1-larsxschneider@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 17 quoted lines

> The Git for Windows CI web app sometimes returns HTTP errors of
> "502 bad gateway" or "503 service unavailable" [1]. We also need to
> check the HTTP content because the GfW web app seems to pass through
> (error) results from other Azure calls with HTTP code 200.
> Wait a little and retry the request if this happens.
>
> [1] https://docs.microsoft.com/en-in/azure/app-service-web/app-service-web-troubleshoot-http-502-http-503
>
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
>
> Hi Junio,
>
> I can't really test this as my TravisCI account does not have the
> extended timeout and I am unable to reproduce the error.
>
> It would be great if we could test this is a little bit in pu.

This has been in 'pu' for a while.

As the patch simply discards 502 (and others), it is unclear if the failing test on 'next' is now gone, or the attempt to run 'pu' happened to be lucky not to get one, from the output we can see in https://travis-ci.org/git/git/jobs/229867212

Are you comfortable enough to move this forward? It's not like a possible breakage in this patch will harm anything (the relaying to the Windows CI is flaky if the build server cannot deal with the load anyway), so I would rather have this early in 'next', while we deal with a few other topics that Windows build is not happy with that are on 'pu'.