Re: `pull --rebase --autostash` fails when fast forward in dirty repo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 25, 2017, 23:33 UTC
- Message-ID
- <xmqqpoewcy05.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170525182230.552dif62zqxuufk3@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> Anyway. All this has shown me is that it's probably pointless to do this > timing at all on Linux. Somebody on Windows might get better results. > > But regardless, we need to do something. Correctness must trump > optimizations, and the question is whether we can throw out the whole > conditional, or if we should just restrict when it kicks in.
Yes. I personally do not mind going with the simplest approach. The optimization thing is relatively new and we were perfectly happy without it before ;-).