git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 3/6] t0021: write "OUT <size>" only on success

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 27, 2017, 21:26 UTC
Message-ID
<xmqqpodpyvep.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<BEB23654-54FB-40B0-8C7B-E70D1E5BBCF7@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 13 quoted lines
> Correct! Sorry for the confusion. How about this?
>
>     "rot13-filter.pl" always writes "OUT <size>" to the debug log at the end
>     of a response.
>
>     This works perfectly for the existing responses "abort", "error", and 
>     "success". A new response "delayed", that will be introduced in a
>     subsequent patch, accepts the input without giving the filtered result
>     right away. At this point we cannot know the size of the response.
>     Therefore, we do not write "OUT <size>" for "delayed" responses.
>
>     To simplify the code we do not write "OUT <size>" for "abort" and
>     "error" responses either as their size is always zero.
That unconfuses me tremendously.

Unless there are other issues in v7 (which I am not aware of but there may be somebody else slow responding), I plan to amend the log message with the above, so no need to resend.

Thanks.
Previous: Lars SchneiderNext: Lars Schneider
Message 7 of 15 in “convert: add "status=delayed" to filter process protocol”
  1. 0/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 27, 2017
  2. 1/6 t0021: keep filter log files on comparisonLars Schneider, Jun 27, 2017
  3. 2/6 t0021: make debug log file name configurableLars Schneider, Jun 27, 2017
  4. 3/6 t0021: write "OUT <size>" only on successLars Schneider, Jun 27, 2017
  5. Junio C HamanoJun 27, 2017
  6. Lars SchneiderJun 27, 2017
  7. Junio C HamanoJun 27, 2017
  8. 6/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 27, 2017
  9. Junio C HamanoJun 27, 2017
  10. Lars SchneiderJun 27, 2017
  11. Junio C HamanoJun 27, 2017
  12. Lars SchneiderJun 27, 2017
  13. Lars SchneiderJun 27, 2017
  14. 5/6 convert: move multiple file filter error handling to separate functionLars Schneider, Jun 27, 2017
  15. 4/6 convert: put the flags field before the flag itself for consistent styleLars Schneider, Jun 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.