Re: [Proposed] Externalize man/html ref for quick-install-man and quick-install-html

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 12, 2017, 23:40 UTC
Message-ID: <xmqqpo7jy0pe.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <004b01d373a0$3ec759d0$bc560d70$@nexbridge.com>

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

Show 12 quoted lines

> Yes, needed. The lines wrapped om Documentation/Makefile - each
> change in quick-install-man/html should be exactly one line:
>
> quick-install-man: require-manrepo
> -	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(MAN_REPO) $(DESTDIR)$(mandir)
> +	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(MAN_REPO) $(DESTDIR)$(mandir) $(GIT_MAN_REF)
>  
> And here
>
>  quick-install-html: require-htmlrepo
> -	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(HTML_REPO) $(DESTDIR)$(htmldir)
> +	'$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(HTML_REPO) $(DESTDIR)$(htmldir) $(GIT_MAN_REF)

I somehow have a feeling that you are not even looking at the right rendition.

To everybody else who did not complain that what I sent was line-wrapped, the message should be showing like this:

    https://public-inbox.org/git/xmqqtvwvy1rh.fsf@gitster.mtv.corp.google.com/

Perhaps the mail program on your receiving end is mangling what you got from the mailing list, giving you a line-wrapped version.

It also unfortunately makes me suspect that you didn't actually have a chance to apply the patch mechanically and make sure it works for you due to mail mangling at your end X-<.

> And otherwise please consider it signed off.

Will do, thanks.