Re: [PATCH v2 1/7] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 28, 2017, 19:40 UTC
Message-ID: <xmqqpo6yk5dh.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171226215908.425-2-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

Show 17 quoted lines

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  t/perf/aggregate.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
> index e401208488..769d418708 100755
> --- a/t/perf/aggregate.perl
> +++ b/t/perf/aggregate.perl
> @@ -70,7 +70,7 @@ if (not @tests) {
>  }
>  
>  my $resultsdir = "test-results";
> -if ($ENV{GIT_PERF_SUBSECTION} ne "") {
> +if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {
>  	$resultsdir .= "/" . $ENV{GIT_PERF_SUBSECTION};
>  }

It appears that this is the only remaining environment variable reference that could trigger comparison between undef and "" that may be flagged by use of strict & warnings? A good change.