git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Correct mispellings of ".gitmodule" to ".gitmodules"

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 14, 2018, 19:37 UTC
Message-ID
<xmqqpo57mkgw.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<alpine.LFD.2.21.1802131907480.17291@localhost.localdomain>
"Robert P. J. Day" <rpjday@crashcourse.ca> writes:
Show 17 quoted lines
> There are a small number of misspellings, ".gitmodule", scattered
> throughout the code base, correct them ... no apparent functional
> changes.
>
>  Documentation/technical/api-submodule-config.txt | 2 +-
>  contrib/subtree/git-subtree.txt                  | 2 +-
>  submodule-config.c                               | 4 ++--
>  t/t5526-fetch-submodules.sh                      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
>   can't believe i forgot to sign my own patch. le *sigh* ...
>
> diff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt

Just for future reference, the diffstat and summary comes _after_ the three-dash line, before which is your sign-off, and after which you can have additional comment like "can't believe...".

No need to resend, as I can remove the cruft from the log message while queuing.

Thanks.  The patch looks good.  Will queue.
Previous: Robert P. J. Day
Message 2 of 2 in “Correct mispellings of ".gitmodule" to ".gitmodules"”
  1. Correct mispellings of ".gitmodule" to ".gitmodules"Robert P. J. Day, Feb 14, 2018
  2. Junio C HamanoFeb 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.