Re: [PATCH 1/9] Makefile: add a hdr-check target

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2018, 18:49 UTC
Message-ID: <xmqqpnx8ypf5.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <b7b9b26d-c175-05b9-7144-101bcaf592d4@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 11 quoted lines

> Yes, this was one of my first concerns (I even asked Elijah what
> compiler options he used), but I was getting useful results without
> passing CFLAGS, so I just ignored that issue ... :-D
> ...
> Indeed. This bothered me as well. The 'compat' directory does not
> follow the 'usual pattern' of the main headers and is particularly
> sensitive to the lack of various -DMACROs. I had initially included
> _all_ sub-directories in the 'exclude list' (to follow what Elijah
> had done), but then removed one at a time ...
>
> I am open to suggestions for improvements. ;-)

Perhaps it is sufficient to add a mention of these two issues in log message and an in-code comment nearby the .hco rule in Makefile, so that people can come back later to discover what design choice we made (i.e. "without worrying about these two issues, we are getting useful enough results, so we decided it is OK at least for now not to worry about them").

Thanks.