git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v3 3/3] t0000: use test_line_count instead of wc -l

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2019, 08:15 UTC
Message-ID
<xmqqpnqozjh1.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<87ftrkab2w.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 8 quoted lines
> No objections to changing this, but I don't think it's the fault of a
> commit message if someone reading it doesn't get an explanation for a
> future unrelated improvement.
>
> The times when a commit should have such an explanation are cases like
> e.g. introducing a function that's not used yet to make a subsequent
> commit smaller, or other such cases where the change is incomplete in
> some way.

Deliberately omitting an obvious improvement "while at it" would be similar to adding a function that is not used yet. Careful readers notice "why don't do it at this step while touching the same area?" just like they would notice "why do it at this step when it is not yet used?". While it certainly is *not* required, they would find it helpful to answer such questions, erring on the safer side.

Previous: Ævar Arnfjörð Bjarmason
Message 11 of 11 in “Avoid using pipes”
  1. Jonathan ChangMar 17, 2019
  2. [GSoC][PATCH v3 1/3] t0000: fix indentationJonathan Chang, Mar 17, 2019
  3. [GSoC][PATCH v3 2/3] t0000: avoid using pipesJonathan Chang, Mar 17, 2019
  4. Ævar Arnfjörð BjarmasonMar 17, 2019
  5. jonathan changMar 24, 2019
  6. Ævar Arnfjörð BjarmasonMar 24, 2019
  7. [GSoC][PATCH v3 3/3] t0000: use test_line_count instead of wc -lJonathan Chang, Mar 17, 2019
  8. Ævar Arnfjörð BjarmasonMar 17, 2019
  9. Thomas GummererMar 17, 2019
  10. Ævar Arnfjörð BjarmasonMar 18, 2019
  11. Junio C HamanoMar 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.