git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Sometimes unable to lock the index during pre-commit hook

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 10, 2019, 07:26 UTC
Message-ID
<xmqqpni0jioq.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAE0unxyojHVWP4aM3C+DdMYORmcoCuq-0wwLGjE8ok6dLj_E8w@mail.gmail.com>
Réda Housni Alaoui <reda.housnialaoui@gmail.com> writes:
> Are pre-commit hooks expected to be able to manipulate the index?

Hooks are described in githooks(5) manual pages; we may want to clarify what is not allowed, but back when most of the entries were written, the stance was that anything that is not explicitly allowed there is forbidden.

In general, a pre-<something> hook is a way to inspect (i.e. look but not touch) what is proposed to be done and veto it by exiting with non-zero. It is not expected to change the state of the repository in any way.

The code does not necessarily enforce it, because it is costly to take a snapshot of everything (including the index, the working tree files, the files that are untracked, the objects in the object database, etc.) before calling a hook and ensure that the hook did not touch anything.

Thanks.
Previous: Réda Housni AlaouiNext: Réda Housni Alaoui
Message 2 of 5 in “Sometimes unable to lock the index during pre-commit hook”
  1. Réda Housni AlaouiNov 9, 2019
  2. Junio C HamanoNov 10, 2019
  3. Réda Housni AlaouiNov 10, 2019
  4. Junio C HamanoNov 11, 2019
  5. Réda Housni AlaouiNov 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.