Re: [PATCH] import-tars: ignore the global PAX header

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2020, 21:53 UTC
Message-ID: <xmqqpnd23fhg.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2003232158160.46@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 6 quoted lines

> The tar importer in `contrib/fast-import/import-tars.perl` has a very
> convenient feature that I took for public knowledge: if _all_ paths stored
> in the imported `.tar` start with a common prefix, e.g.
> `my-project-1.0.0/` as indicated in the commit message (or `git-2.26.0/`
> in the tar at https://github.com/git/git/archive/v2.26.0.tar.gz), then
> this prefix is stripped.

Ahh, scratch what I said in my recent response. No, the above is not public knowledge, and that was missing from the log message that confused me.

With that spelled out, yes, it makes sense not to allow the phony "file" at the top level created out of the pax headers.

So, I think with a bit more explanation in the log, the patch would be OK. We do not want _any_ header.

Thanks.