git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/test_lib: avoid naked bash arrays in file_lineno

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2020, 01:17 UTC
Message-ID
<xmqqpnbf1aze.fsf@gitster.c.googlers.com>
In-Reply-To
<20200508005817.GA24664@Carlos-MBP>
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
Show 13 quoted lines
> On Thu, May 07, 2020 at 09:52:12PM +0200, Johannes Schindelin wrote:
>> On Wed, 6 May 2020, Carlo Marcelo Arenas Belón wrote:
>> >
>> > Enclose the bash specific code inside an eval to avoid parsing errors
>> > and while at it, simplify the logic so that instead of traversing the
>> > callstack just pop the two topmost entries that are required.
>> 
>> I would be okay with that, but that's not what the patch does:
>
> FWIW that was the intention, but luckily Junio quickly predicted it was
> most likely buggy and so has been since made obsolete by:
>
>   https://lore.kernel.org/git/20200507175706.19986-1-carenas@gmail.com/

Heh, don't give me too much credit. I just noticed that they cannot be implementing the same thing, but I couldn't tell if the new behaviour was something you two agreed to be better, and asked for a clarification.

In any case, the "just protect with eval '' block to avoid hurting other shells" version should be the first step. Improving it further is a separate topic.

Thanks.
Previous: Carlo Marcelo Arenas Belón
Message 8 of 8 in “t/test_lib: avoid naked bash arrays in file_lineno”
  1. t/test_lib: avoid naked bash arrays in file_linenoCarlo Marcelo Arenas Belón, May 7, 2020
  2. Junio C HamanoMay 7, 2020
  3. Carlo ArenasMay 7, 2020
  4. t/test_lib: avoid naked bash arrays in file_linenoCarlo Marcelo Arenas Belón, May 7, 2020
  5. Johannes SchindelinMay 8, 2020
  6. Johannes SchindelinMay 7, 2020
  7. Carlo Marcelo Arenas BelónMay 8, 2020
  8. Junio C HamanoMay 8, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.