git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] doc: `--date` in `git-commit` accepts approxidates

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 23, 2021, 19:34 UTC
Message-ID
<xmqqpn0q1stv.fsf@gitster.g>
In-Reply-To
<YDVSICgBwPLtDNu4@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> On Tue, Feb 23, 2021 at 06:52:02PM +0000, Utku Gultopu via GitGitGadget wrote:
>
>> +ifdef::git-commit[]
>> +In addition to recognizing all date formats above, the `--date` option
>> +will also try to make sense of other, more human-centric date formats,
>> +such as relative dates like "yesterday" or "last Friday at noon". For
>> +further details on what kind of formats are accepted, please refer to
>> +the `approxidate_careful` function in `date.c` file in Git source code.
>> +endif::git-commit[]
>
> OK. This is still referring to `approxidate_careful`, which may not be
> meaningful to most users. But at least it makes a best effort at a
> hand-waving definition before then. :)
>
> I'd probably omit the final sentence entirely (as it may simply confuse
> people who don't know how to find Git's source), but I'm OK with it
> either way.

I am not happy with reference to approxidate_careful that has no place in end-user facing documentation. I think the one you suggested struck a better balance.

Previous: Jeff KingNext: Utku
Message 6 of 9 in “doc: `--date` in `git-commit` accepts approxidates”
  1. doc: `--date` in `git-commit` accepts approxidatesUtku Gultopu via GitGitGadget, Feb 23, 2021
  2. Jeff KingFeb 23, 2021
  3. Junio C HamanoFeb 23, 2021
  4. doc: `--date` in `git-commit` accepts approxidatesUtku Gultopu via GitGitGadget, Feb 23, 2021
  5. Jeff KingFeb 23, 2021
  6. Junio C HamanoFeb 23, 2021
  7. UtkuFeb 23, 2021
  8. Jeff KingFeb 23, 2021
  9. UtkuFeb 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.