Re: [PATCH] commit-graph: warn about incompatibilities only when trying to write

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2021, 22:21 UTC
Message-ID: <xmqqpn0ims5i.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2103012304580.57@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 25 quoted lines

> Hi,
>
> On Sun, 28 Feb 2021, Ævar Arnfjörð Bjarmason wrote:
>
>> On Fri, Feb 26 2021, Junio C Hamano wrote:
>>
>> > I am tempted to say that we should revert c85eec7f (commit-graph:
>> > when incompatible with graphs, indicate why, 2021-02-11) for the
>> > upcoming release.  That would give us enough time to come up with
>> > and cook the solution in 'next' in the meantime.
>>
>> That's probably sensible.
>
> I agree. This close to v2.31.0, I do not want to rush things.
>
>> Also, I noticed that we went through this whole saga in the past, see
>> 25575015ca (repack: silence warnings when auto-enabled bitmaps cannot be
>> built, 2019-07-31), including breaking background gc.
>
> Sounds like it.
>
> Thank you for your valuable feedback!
>
> Ciao,
> Dscho

Thanks, reverted and started today's integration cycle on top.