Re: [PATCH v7] format-patch: allow a non-integral version numbers

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 19, 2021, 16:01 UTC
Message-ID: <xmqqpmzvnnda.fsf@gitster.g>
In-Reply-To: <pull.885.v7.git.1616152884317.gitgitgadget@gmail.com>

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

>     There is a small question: in the case of --reroll-count=<n>, "n" is an
>     integer, we output "n-1" in the patch instead of "m" specified by
>     --previous-count=<m>,Should we switch the priority of these two: let "m"
>     output?

In principle, if the end-user can explicitly give an input that may (or may not) contradict what the code would automatically compute, we should treat the latter as a fallback default and use it only when the former is not given. So, I would think the answer is "yes, we should use <m> and not <n>-1, if <m> is given".

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.