git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] persistent-https: add go.mod to fix compile

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2021, 22:57 UTC
Message-ID
<xmqqpmzgb66j.fsf@gitster.g>
In-Reply-To
<CAPig+cRmJLkkzsROuUifah2-RgSoEXmLnBDV8-a8iL3jF0CBLQ@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 12 quoted lines
> On Tue, Mar 30, 2021 at 6:07 PM Junio C Hamano <gitster@pobox.com> wrote:
>> In any case, explaining these things in this response is good, but
>> eventually we need to make sure that the readers of the resulting
>> commit would not have to ask the same question, without having to
>> refer to external documentation.
>
> It might also be worthwhile -- for the non-Go readers -- for the
> commit message to mention that this addition of a `go.mod` file does
> not hinder those stuck with old pre-module versions of Go (it doesn't
> help them either, but that's less significant), thus this change does
> not require them to update to a modern version of Go (i.e. we're not
> raising the minimum required version).

Thanks for spelling out the most important part of what the readers should be able to read from the resulting commit. I agree that piece of information is a must.

Previous: Eric Sunshine
Message 6 of 6 in “persistent-https: add go.mod to fix compile”
  1. persistent-https: add go.mod to fix compileDominyk Tiller via GitGitGadget, Mar 30, 2021
  2. Junio C HamanoMar 30, 2021
  3. Dominyk TillerMar 30, 2021
  4. Junio C HamanoMar 30, 2021
  5. Eric SunshineMar 30, 2021
  6. Junio C HamanoMar 30, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.