Re: [PATCH] git-merge: move space to between strings

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 18, 2021, 19:17 UTC
Message-ID: <xmqqpmyr9zcd.fsf@gitster.g>
In-Reply-To: <pull.934.git.1618770806366.gitgitgadget@gmail.com>

"Josh Soref via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 16 quoted lines

> From: Josh Soref <jsoref@gmail.com>
>
> Signed-off-by: Josh Soref <jsoref@gmail.com>
> ---
>     git-merge: move space to between strings
>     
>     GitHub Actions show things like:
>     
>      * branch                  master     -> FETCH_HEAD
>      (nothing to squash)Already up to date.
>     
>     
>     The expected results are:
>     
>      * branch                  master     -> FETCH_HEAD
>     (nothing to squash) Already up to date.

I am not sure if that is THE expected results, though (you wouldn't have got this reaction if you said "I would expect to see").

Usually, it is easier to read a message if it makes its primary point first, before giving a parenthetical note. I.e. I would expect that

	Already up to date (nothing to squash).

would be easier to understand to users.

Thanks.