Re: [PATCH v2 0/5] tests: migrate to "test-tool pkt-line"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 12, 2021, 20:41 UTC
- Message-ID
- <xmqqpmvn2rkm.fsf@gitster.g>
- In-Reply-To
- <cover-0.5-00000000000-20210712T164208Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 38 quoted lines
> This series is marked for "will merge to next" already, but not there
> yet. A trivial v2 whitespace fix in case Junio's in time to pick it
> up.
>
> See v1 at https://lore.kernel.org/git/cover-0.5-00000000000-20210707T101549Z-avarab@gmail.com/
>
> Ævar Arnfjörð Bjarmason (5):
> serve tests: add missing "extra delim" test
> serve tests: use test_cmp in "protocol violations" test
> tests: replace [de]packetize() shell+perl test-tool pkt-line
> tests: replace remaining packetize() with "test-tool pkt-line"
> test-lib-functions.sh: remove unused [de]packetize() functions
>
> t/helper/test-pkt-line.c | 12 +++++
> t/t5410-receive-pack-alternates.sh | 42 +++++++++++++-----
> t/t5411/once-0010-report-status-v1.sh | 12 ++---
> t/t5500-fetch-pack.sh | 15 ++++---
> t/t5530-upload-pack-error.sh | 24 +++++-----
> t/t5562-http-backend-content-length.sh | 16 ++++---
> t/t5570-git-daemon.sh | 22 ++++++----
> t/t5704-protocol-violations.sh | 61 ++++++++++++++++++--------
> t/test-lib-functions.sh | 42 ------------------
> 9 files changed, 135 insertions(+), 111 deletions(-)
>
> Range-diff against v1:
> 1: fcb53980597 = 1: 67aa8141153 serve tests: add missing "extra delim" test
> 2: c3544fb53cd = 2: 64dfd14865c serve tests: use test_cmp in "protocol violations" test
> 3: c1015fa6ab0 = 3: c33f344ab20 tests: replace [de]packetize() shell+perl test-tool pkt-line
> 4: ab23513b48b ! 4: a44e1790f2a tests: replace remaining packetize() with "test-tool pkt-line"
> @@ t/helper/test-pkt-line.c: static void pack(int argc, const char **argv)
>
> +static void pack_raw_stdin(void)
> +{
> -+
> + struct strbuf sb = STRBUF_INIT;
> + strbuf_read(&sb, 0, 0);
> + if (strbuf_read(&sb, 0, 0) < 0)
> 5: 2d22b83971a = 5: cc91d15ef70 test-lib-functions.sh: remove unused [de]packetize() functionsWell, if you care that much, I'd prefer to also see an blank line between the end of decl and the first statement.
;-)