Re: [PATCH v2] i18n: fix typos found during l10n for git 2.34.0

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2021, 16:26 UTC
Message-ID: <xmqqpmrh8atl.fsf@gitster.g>
In-Reply-To: <7d9a893e-5dad-bd21-4ef7-6d47303abdc1@gmail.com>

Bagas Sanjaya <bagasdotme@gmail.com> writes:

Show 15 quoted lines

>> diff --git a/ref-filter.c b/ref-filter.c
>> index 282cdad103..08a3f839c9 100644
>> --- a/ref-filter.c
>> +++ b/ref-filter.c
>> @@ -1037,7 +1037,7 @@ int verify_ref_format(struct ref_format *format)
>>   		     format->quote_style == QUOTE_TCL) &&
>>   		     used_atom[at].atom_type == ATOM_RAW &&
>>   		     used_atom[at].u.raw_data.option == RAW_BARE)
>> -			die(_("--format=%.*s cannot be used with"
>> +			die(_("--format=%.*s cannot be used with "
>>   			      "--python, --shell, --tcl"), (int)(ep - sp - 2), sp + 2);
>>   		cp = ep + 1;
>>   
>
> Why not using \n?

It is not quite clear to me why it should.

Among the possible string that is (ep - sp - 2) bytes long (i.e. --python, --shell, --tcl, --raw), even with the longest, the resulting message would become

    fatal: --format=--python cannot be used with
    --python, --shell, --tcl.

that is unusually short with such a newline in the middle.