Re: [PATCH 0/4] Really retire git-legacy-stash.sh

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2022, 01:59 UTC
Message-ID: <xmqqpmocy60i.fsf@gitster.g>
In-Reply-To: <pull.1133.git.1643321031.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

> After proving out git stash for a very long time as a shell script, we
> eventually converted it to a proper built-in, leaving an escape hatch in
> place to call the scripted version.
>
> After another very long time, we removed that escape hatch, leaving behind a
> warning.
>
> Now, almost two years later, let's remove even that warning (and a couple of
> tidbits that we inadvertently left in the code base).

Yay. We probably could have done this when we disabled the escape hatch, but better late than never ;-)

Show 13 quoted lines

> Johannes Schindelin (4):
>   git-sh-setup: remove remnant bits referring to `git-legacy-stash`
>   add: remove support for `git-legacy-stash`
>   Remove documentation for `stash.useBuiltin`
>   stash: stop warning about the obsolete `stash.useBuiltin` config
>     setting
>
>  Documentation/config/stash.txt |  7 -------
>  builtin/add.c                  | 14 --------------
>  builtin/stash.c                | 10 ----------
>  git-sh-setup.sh                |  1 -
>  t/t3903-stash.sh               | 15 ---------------
>  5 files changed, 47 deletions(-)

It is surprisingly small removal, but matches the explanation above, i.e. the actual old implementation was gone long time ago.

Looking good.

Thanks.