Re: [PATCH] git-gui: add support for filenames starting with tilde

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2023, 18:52 UTC
Message-ID: <xmqqpm1bsqz8.fsf@gitster.g>
In-Reply-To: <pull.1599.git.1697619043944.gitgitgadget@gmail.com>

"Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> From: =?UTF-8?q?Matthias=20A=C3=9Fhauer?= <mha1993@live.de>
>
> When git-gui encounters a file name starting with a tilde character (~),
> TCL "helpfully" expands that tilde into a (probably non-existing) users
> home directory. But in git-gui we're often not dealing with user supplied
> paths, where such an expansion might be expected, but actual names of files.
>
> Prevent TCL from doing tilde expansion on these literal filenames.

I do not have stake in git-gui (or gitk) and take the changes the subsystem owners have decided to take from them, but I have to wonder if this is merely robbing Peter to pay Paul?

If the above description were not "we're often not" but "the only paths we use are repository relative, and a path that begin with a tilde NEVER refers to somebody's home directory", then I would buy into the change (but again, I am not even a user of git-gui, so take this with a moderate grains of salt).

Thanks.