Re: [PATCH v2 00/11] meson: a couple of additions
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 14, 2025, 17:46 UTC
- Message-ID
- <xmqqplkp47b4.fsf@gitster.g>
- In-Reply-To
- <20250114-b4-pks-meson-additions-v2-0-8d7ec676cfd9@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> - VN=$(git -C "$SOURCE_DIR" describe --match "v[0-9]*" HEAD 2>/dev/null) && > -+ VN=$(git -C "$SOURCE_DIR" describe --match --dirty "v[0-9]*" 2>/dev/null) && > ++ VN=$(git -C "$SOURCE_DIR" describe --dirty --match="v[0-9]*" 2>/dev/null) &&
Ahh, you only said "found the issue" and it was building suspense ;-)
It turns out that I wasn't affected while testing because my build infrastructure around "make" computes the version string by itself independently from what "make/GIT-VERSION-GEN" does, and stuffs it in the 'version' file, before running "make install". And that is why I didn't notice the breakage before Ramsay reported X-<.
This fix looks obviously good.
Thanks.