Re: [PATCH v2] SubmittingPatches: allow non-real name contributions
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 16, 2025, 14:41 UTC
- Message-ID
- <xmqqple0dwpa.fsf@gitster.g>
- In-Reply-To
- <20250716002523.1392423-1-sandals@crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> Note that this policy is the same as that of the Linux kernel[0] and the > CNCF[1], as well as many smaller projects. The Linux kernel patch was > Acked-by one of the Linux Foundation's lawyers, Michael Dolan, so it > appears these changes have had legal review.
I understand what this wants to say, but found it a tiny bit misleading. The kernel and CNCF do not agree with the exact wording, and this one copies from neither, so "policy is the same" is really "policy is in the same in spirit, even though the text to spell out that policy used by all these three projects differ".
Which is not a bad thing at all, but was a bit misleading.
Show 10 quoted lines
> Additionally, retain the section header ID for ease of linking across > versions. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 > [1] https://github.com/cncf/foundation/blob/659fd32c86dc/dco-guidelines.md > > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> > --- > Documentation/SubmittingPatches | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-)
The text with the patch applied is great. Let's merge it down quickly to 'master'.
Thanks.
Show 22 quoted lines
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index 958e3cc3d5..86ca7f6a78 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -408,8 +408,15 @@ your patch differs from project to project, so it may be different > from that of the project you are accustomed to. > > [[real-name]] > -Also notice that a real name is used in the `Signed-off-by` trailer. Please > -don't hide your real name. > +Please use a known identity in the `Signed-off-by` trailer, since we cannot > +accept anonymous contributions. It is common, but not required, to use some form > +of your real name. We realize that some contributors are not comfortable doing > +so or prefer to contribute under a pseudonym or preferred name and we can accept > +your patch either way, as long as the name and email you use are distinctive, > +identifying, and not misleading. > + > +The goal of this policy is to allow us to have sufficient information to contact > +you if questions arise about your contribution. > > [[commit-trailers]] > If you like, you can put extra trailers at the end: