Re: [PATCH v2 1/3] reflog: name the strings that mark switches, renames and rebase steps
Harald Nordgren <haraldnordgren@gmail.com> writes:
Show 16 quoted lines
> On Fri, Oct 23, 2026 at 11:19 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>> > Name the strings once in reflog.h and use the names wherever the
>> > messages are written or read: the "checkout: moving from " prefix
>> > written by "git checkout", the "Branch: renamed " prefix written by
>> > "git branch -m", and the "start", "finish" and "abort" steps written
>> > by "git rebase".
>> >
>> > No change in behavior.
>>
>> Would it make sense to test the behaviour to demonstrate this claim?
>
> We have previous tests for this which I think would break if this was
> incorrectly refactored.
OK, if we have sufficient coverage, that would be fine.