Re: [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2014, 20:05 UTC
Message-ID: <xmqqob1rt33v.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1393604774-19480-1-git-send-email-sunheehnus@gmail.com>

Sun He <sunheehnus@gmail.com> writes:

Show 8 quoted lines

> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
> The tmpname is uninitialized and it should a bug
>
> Please ignore the former patches about this with wrong format.
> I am sorry to cause a jam in your inbox. ^_^
>
> In the end, I wanna thank Michael Haggerty who give me help.

If you look at "git log" output, you would notice that people write something like

	Helped-by: Michael Haggerty <mhagger@alum.mit.edu>

before your S-o-b: line for a case like this.

We can see that you are replacing tmpname with pack_tmp_name in warning without you writing on the subject line. The commit log is where you explain *why* that change is the right thing to do. And that is totally lacking in this message.

Show 16 quoted lines

>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>  				utb.modtime = --last_mtime;
>  				if (utime(pack_tmp_name, &utb) < 0)
>  					warning("failed utime() on %s: %s",
> -						tmpname, strerror(errno));
> +						pack_tmp_name, strerror(errno));
>  			}
>  
>  			/* Enough space for "-<sha-1>.pack"? */