git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bash prompt "namespace" issue

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2014, 18:52 UTC
Message-ID
<xmqqoaz1o6je.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140513081849.5dql886xw080ww88@webmail.informatik.kit.edu>
szeder@ira.uka.de writes:
Show 7 quoted lines
> Commit 59d3924fb (prompt: fix missing file errors in zsh) added the  
> helper function eread() to git-prompt.sh.  That function should be in  
> the git "namespace", i.e. prefixed with __git_, otherwise it might  
> collide with a function of the same name in the user's environment.
>
> It's already in master and I don't have the means to send a patch  
> fixing this ATM, sorry.

Thanks. I think the patch Felipe posted to rename it to __git_eread is a reasonable regression fix, so I'll queue it on top of the problematic commit 59d3924f (prompt: fix missing file errors in zsh, 2014-04-11) and merge the result to 'master'.

Previous: szeder@ira.uka.de
Message 2 of 2 in “Bash prompt "namespace" issue”
  1. szeder@ira.uka.deMay 13, 2014
  2. Junio C HamanoMay 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.