Re: [PATCH 2/2] commit: allow core.commentChar=auto for character auto selection

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2014, 17:38 UTC
Message-ID: <xmqqoayxaakf.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140516164053.GB12314@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 24 quoted lines

> Nguyễn Thái Ngọc Duy wrote:
>
>> core.commentChar starts with '#' as in default but if it's already in
>> the prepared message, find another one among a small subset. This
>> should stop surprises because git strips some lines unexpectedly.
>
> Probably worth mentioning this only kicks in if someone explicitly
> configures [core] commentchar = auto.
>
> Would it be a goal to make 'auto' the default eventually if people
> turn out to like it?
>
> [...]
>> --- a/builtin/commit.c
>> +++ b/builtin/commit.c
>> @@ -594,6 +594,40 @@ static char *cut_ident_timestamp_part(char *string)
>>  	return ket;
>>  }
>>  
>> +static void adjust_comment_line_char(const struct strbuf *sb)
>> +{
>> +	char candidates[] = " @!#$%^&|:;~";
>
> This prefers '@' over '#'.  Intended?

I think the candidates[0] will almost always be overridden with "#" so it probably does not matter in practice, but I tend to agree that "#" (and probably ";") should come before all others.