Re: [PATCH] t5551: fix the 50,000 tag test

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 10, 2014, 05:53 UTC
Message-ID: <xmqqoay1b99g.fsf@gitster.dls.corp.google.com>
In-Reply-To: <53967F48.1080103@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

> Thanks for digging, as we now know better:
> do you want to squeeze in someting like this:
>
> s/Since the day/Since commit 5e2c7cd2/

I usually do not dig only to give suggestions to others, which will risk the time I spent to go to total waste. When I find the log message lacking, and if the patch looked otherwise OK enough, I do the digging myself in order to tweak to reduce one round-trip (otherwise I'd just discard and tell the submitter to do the digging). I may send out what I learned as a response, but that is a mere "side effect"; the primary effect of queuing an improved patch has often already happened when you see the result of my digging.

I do not recall what I did for this particular patch, but you should be able to fetch and run "git log origin/master..origin/pu" to find out what I did ;-).

Thanks.