git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] imap-send: simplify v_issue_imap_cmd() and get_cmd_result() using starts_with()

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 2, 2014, 19:23 UTC
Message-ID
<xmqqoauxzv1f.fsf@gitster.dls.corp.google.com>
In-Reply-To
<5401F860.4030902@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 25 quoted lines
> Use starts_with() instead of memcmp() to check if NUL-terminated
> strings match prefixes.  This gets rid of some magic string length
> constants.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  imap-send.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index 524fbab..b079a0d 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -802,7 +802,10 @@ static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
>  				resp = DRV_OK;
>  			else {
>  				if (!strcmp("NO", arg)) {
> -					if (cmdp->cb.create && cmd && (cmdp->cb.trycreate || !memcmp(cmd, "[TRYCREATE]", 11))) { /* SELECT, APPEND or UID COPY */
> +					if (cmdp->cb.create && cmd &&
> +					    (cmdp->cb.trycreate ||
> +					     starts_with(cmd, "[TRYCREATE]"))) {
> +						/* SELECT, APPEND or UID COPY */
>  						p = strchr(cmdp->cmd, '"');
>  						if (!issue_imap_cmd(ctx, NULL, "CREATE \"%.*s\"", (int)(strchr(p + 1, '"') - p + 1), p)) {
>  							resp = RESP_BAD;

Do we want this hunk, given that it will disappear with the tf/imap-send-create topic at e0d8e308 (imap-send: create target mailbox if it is missing, 2014-08-01)?

Previous: René ScharfeNext: René Scharfe
Message 2 of 3 in “imap-send: simplify v_issue_imap_cmd() and get_cmd_result() using starts_with()”
  1. imap-send: simplify v_issue_imap_cmd() and get_cmd_result() using starts_with()René Scharfe, Aug 30, 2014
  2. Junio C HamanoSep 2, 2014
  3. René ScharfeSep 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.