Re: [PATCH] credential-cache: close stderr in daemon process
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2014, 21:38 UTC
- Message-ID
- <xmqqoaug4la4.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140914073506.GA19667@peff.net>
Jeff King <peff@peff.net> writes:
> + if (!debug)
> + freopen("/dev/null", "w", stderr);I am getting this:
credential-cache--daemon.c:216:10: error: ignoring return value of 'freopen', declared with attribute warn_unused_result [-Werror=unused-result]
which is somewhat irritating. Even though I am not irritated by this code, but by the compiler and glibc headers, this is apparently the only offending one, so we may want to fix it anyway.