Re: Bug/request: the empty string should be a valid git note

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 22, 2014, 17:39 UTC
Message-ID: <xmqqoau7lfm3.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1A2394C0-50A4-40F4-B0B9-B2EC38109083@gmail.com>

"Kyle J. McKay" <mackyle@gmail.com> writes:

Show 22 quoted lines

> On Sep 20, 2014, at 18:44, Johan Herland wrote:
>
>> At least, we should fix
>>
>>    git notes add -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
>>
>> Whether we should also change
>>
>>    git notes add -m ''
>>
>> to create an empty note, or leave it as-is, (i.e. similar in spirit to
>> "git commit -m ''"), I'll leave up to further discussion.
>
> The help for git commit has this:
>
>   --allow-empty-message
>     Like --allow-empty this command is primarily for use by
>     foreign SCM interface scripts. It allows you to create
>     a commit with an empty commit message without using
>     plumbing commands like git-commit-tree(1).
>
> Why not add the same/similar option to git notes add?

Sounds like a good direction to go.