git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] sha1_file: implement changes for "cat-file --literally -t"

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 5, 2015, 06:25 UTC
Message-ID
<xmqqoao83qrd.fsf@gitster.dls.corp.google.com>
In-Reply-To
<54F7B0CE.4070006@gmail.com>
karthik nayak <karthik.188@gmail.com> writes:
>> Looks suspiciously familiar...
> Yes, you suggested it.
> It has a similar structure to unpack_sha1_header().
> Anything wrong with it?

I don't know if there is something wrong with the code, or not, but it wasn't mentioned in the log message at all that it is not your code, and I was mostly reacting to that.

It is fairly common around here to take somebody else's code and run with it, but people say things like "This is based on suggestion from X", "This function was stolen from Y", etc. and then conclude with "but I adjusted it to match the caller I wrote, so bugs are mine." when they do so.

Previous: karthik nayakNext: Karthik Nayak
Message 6 of 7 in “cat-file: add "--literally" option”
  1. 0/3 cat-file: add "--literally" optionkarthik nayak, Mar 3, 2015
  2. 1/3 cache: modify for "cat-file --literally -t"Karthik Nayak, Mar 3, 2015
  3. 2/3 sha1_file: implement changes for "cat-file --literally -t"Karthik Nayak, Mar 3, 2015
  4. Junio C HamanoMar 4, 2015
  5. karthik nayakMar 5, 2015
  6. Junio C HamanoMar 5, 2015
  7. 3/3 cat-file: add "--literally" optionKarthik Nayak, Mar 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.