git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] parse-options: fix the description of defval

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 29, 2015, 18:18 UTC
Message-ID
<xmqqoanby8e0.fsf@gitster.dls.corp.google.com>
In-Reply-To
<BE8DB6BF-DB95-4D9B-A01B-3D3BCE4C3C9C@gmail.com>
Ivan Ukhov <ivan.ukhov@gmail.com> writes:
Show 16 quoted lines
> Hello Junio,
>
>
> Yes, actually my intention to fix that comment was solely based on its
> content. I saw that the elements in the first set, {BIT,SET_INT}, did
> not match the elements in the second, {mask,integer,pointer}. Then I
> found that commit removing OPT_SET_PTR, and “pointer” seemed to be a
> leftover, which I decided to eliminate. My commit message was saying
> something different, I should admit)
>
> I totally agree with your about mentioning only the general principle
> and leaving details to particular macros.
>
>
> Regards,
> Ivan

OK, lest we forget, please send an updated patch marked as v2 with proposed commit log message that does not say something different, then ;-)

Thanks.
Previous: Ivan Ukhov
Message 8 of 8 in “parse-options: fix the description of defval”
  1. parse-options: fix the description of defvalIvan Ukhov, Mar 29, 2015
  2. Paul TanMar 29, 2015
  3. Ivan UkhovMar 29, 2015
  4. Paul TanMar 29, 2015
  5. Ivan UkhovMar 29, 2015
  6. Junio C HamanoMar 29, 2015
  7. Ivan UkhovMar 29, 2015
  8. Junio C HamanoMar 29, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.