Re: [PATCH v4 2/8] t5520: test no merge candidates cases

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2015, 17:46 UTC
Message-ID: <xmqqoalhdbhx.fsf@gitster.dls.corp.google.com>
In-Reply-To: <e89b333476cbb1e546371a07b357cd42@www.dscho.org>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 13 quoted lines

>> +test_expect_success 'fail if wildcard spec does not match any refs' '
>> +	git checkout -b test copy^ &&
>> +	test_when_finished "git checkout -f copy && git branch -D test" &&
>
> When I read this line, I immediately asked myself whether the
> branch would be deleted even if the test case failed. I then
> tested this theory by editing the first test case ("setup") like
> this:
> ...
> and indeed, the file "file" was gone, even if the test case
> failed. I therefore believe that this "test_when_finished" cleanup
> might make debugging substantially harder. Maybe we can drop these
> lines from this patch?

The test framework is aware of the fact that it needs to help the people who are debugging the scripts. The support is limited to the case in which you run it under the -i option, i.e.

	$ cd t
        $ sh ./t5520-pull.sh -i -v

will refrain from running test_when_finished scripts when the test piece fails. Even though this is only limited to -i, I found it often sufficient for debugging.