Re: Multiple fetches when unshallowing a shallow clone

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2015, 21:57 UTC
Message-ID: <xmqqoae5ri5x.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20151204212712.GA22493@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 24 quoted lines

> This seems to reproduce consistently for me:
>
>   $ git clone --depth=1 git://github.com/git/git
>   Cloning into 'git'...
>   remote: Counting objects: 2925, done.
>   remote: Compressing objects: 100% (2602/2602), done.
>   remote: Total 2925 (delta 230), reused 2329 (delta 206), pack-reused 0
>   Receiving objects: 100% (2925/2925), 6.17 MiB | 10.80 MiB/s, done.
>   Resolving deltas: 100% (230/230), done.
>
>   $ cd git
>   $ git fetch --unshallow
>   remote: Counting objects: 185430, done.
>   remote: Compressing objects: 100% (46933/46933), done.
>   remote: Total 185430 (delta 140505), reused 181589 (delta 136694), pack-reused 0
>   Receiving objects: 100% (185430/185430), 52.80 MiB | 10.84 MiB/s, done.
>   Resolving deltas: 100% (140505/140505), completed with 1784 local objects.
>   remote: Counting objects: 579, done.
>   remote: Compressing objects: 100% (579/579), done.
>   remote: Total 579 (delta 0), reused 579 (delta 0), pack-reused 0
>   Receiving objects: 100% (579/579), 266.85 KiB | 0 bytes/s, done.
>   [... fetch output ...]
>
> That looks like two packs being received for the --unshallow case.

What is puzzling is that I do not seem to see this "two fetches" with the local transport. I only see "deepen 2147483647" in the protocol log.

Moreover, the only interesting lines in the output from

    $ git grep -B1 'deepen ' \*.[ch]

are

fetch-pack.c- if (args->depth > 0) fetch-pack.c: packet_buf_write(&req_buf, "deepen %d", args->depth);

so I do not see how anybody would be sending "deepen 0" as Jason saw.