git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] utf8: fix duplicate words of "the"

From
Junio C Hamano <gitster@pobox.com>
Date
May 6, 2016, 17:28 UTC
Message-ID
<xmqqoa8j3xk7.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160506130922.GA5051@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> On Fri, May 06, 2016 at 08:31:33PM +0800, Li Peng wrote:
>
>> Fix duplicate words of "the" in comment.
>
> Obviously a good change, along with the other one of mine you found.
>
>> ---
>>  transport-helper.c | 2 +-
>>  utf8.h             | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> You seem to be breaking these up by file; was the change in
> transport-helper supposed to be in a different patch?
>
> IMHO it would be fine to just do all of these in a single patch. They're
> different files, yes, but it's all conceptually the same change.
>
> -Peff

I can squash them into a single one. So far, everything except two I saw was good.

Previous: Jeff KingNext: Junio C Hamano
Message 3 of 5 in “utf8: fix duplicate words of "the"”
  1. utf8: fix duplicate words of "the"Li Peng, May 6, 2016
  2. Jeff KingMay 6, 2016
  3. Junio C HamanoMay 6, 2016
  4. Junio C HamanoMay 6, 2016
  5. 回复:[PATCH] utf8: fix duplicate words of "the"李三0159, May 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.