Re: [PATCH] crlf: Add test showing double warning on commit

From: Junio C Hamano <gitster@pobox.com>
Date: May 14, 2016, 18:45 UTC
Message-ID: <xmqqoa887a25.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <baea5604-e786-5773-aa68-f311efb23752@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

> Do we need to run diff_populate_filespec() twice when src==dst ?

Of course we do.

src and dst may have the same path, but are coming from different places (src may be an indexed blob while dst may be a file in the working tree).

> If yes, we may need to introduce a flag besides
> #define CHECK_SIZE_ONLY 1
> #define CHECK_BINARY    2
> to suppress the conversion warning ??

I do not think that belongs to diff_populate_filespec() at all.

Why should conversion routine give this warning when called by diff_populate_filespec() in the first place? Shouldn't it be silent by default, and is allowed to talk _ONLY_ when we are attempting to actually replace the data in the index, e.g. "git add" and "git commit -a"?