Re: [PATCH v12 0/8] submodule inline diff format
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 1, 2016, 01:08 UTC
- Message-ID
- <xmqqoa48xw8j.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160831232725.28205-1-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 11 quoted lines
> @@ -523,8 +523,10 @@ char *git_pathdup_submodule(const char *path, const char *fmt, ...)
> va_start(args, fmt);
> err = do_submodule_path(&buf, path, fmt, args);
> va_end(args);
> - if (err)
> + if (err) {
> + strbuf_release(&buf);
> return NULL;
> + }
> return strbuf_detach(&buf, NULL);
> }Thanks. My copy was lacking this hunk. Will replace.