Re: [PATCH] send-email: new option to walkaround email server limits

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2017, 01:54 UTC
Message-ID: <xmqqo9vdiboz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170429122632.7122-1-zxq_yx_007@163.com>

xiaoqiang zhao <zxq_yx_007@163.com> writes:

> Some email server(e.g. smtp.163.com) limits a fixed number emails to be send per
> session(connection) and this will lead to a send faliure.

That sounds painful.

> With --split <num> option, a auto reconnection will occur when number of sended
> email reaches <num> and the problem is solved.

Two nits (other than s/sended/sent/ and s/$send_count/$num_sent/):

 - "--split" sounds as if you are splitting a single large message
   into multiple pieces, which of course is not what is going on
   here.  We need to find a better name for the option.  Perhaps
   "--batch-size=<num>", "--max-messages-per-connection=<num>" or
   something?

 - The code seems to do the "logging out and the logging back in"
   dance without any delay in between.  Is it something we want to
   consider to add a small (possibly configurable) delay in between?

Thanks.