Re: [PATCH 01/11] string_list: print_string_list to use trace_printf

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2018, 09:53 UTC
Message-ID: <xmqqo9d9y6oy.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180907000423.GA16764@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> I guess the question is: is this a thing we would want to make available
> to code to leave in all the time? Or is it just for sticking in
> temporarily for a quick dump?
>
> If the former, then I think it needs the early-return at the least (and
> probably _should_ have the key parameter).
>
> But I get the feeling that you really just want the latter, and are only
> grudgingly being pushed into the former by Junio's suggestion.

Well, if that is the case, I'd change "my suggestion" (although I didn't mean to suggest anything concrete). If this was needed and/or was useful only during the defvelopment of the remainder of the series, and if this is known to be a half-hearted change that is not meant to be useful as a general solution, then let's not take the main part of the series a hostage to this step; rather, we should drop this change and leave it to another series that is willing to do it right. It would save both author's and reviewers' time if we did so.