Re: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 3, 2019, 22:09 UTC
Message-ID: <xmqqo98xfl6g.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <007901d4a3b0$5dd1d030$19757090$@nexbridge.com>

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

Show 24 quoted lines

> On January 3, 2019 16:38, Eric Sunshine wrote:
>> On Thu, Jan 3, 2019 at 4:04 PM <randall.s.becker@rogers.com> wrote:
>> > A number of configuration options are not automatically detected by
>> > configure mechanisms, including the location of Perl and Python.
>> >
>> > There was a problem at a specific set of operating system versions
>> > that caused getopt to have compile errors. Account for this by
>> > providing emulation defines for those versions.
>> >
>> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
>> > ---
>> > diff --git a/config.mak.uname b/config.mak.uname @@ -470,7 +487,7
>> @@
>> > ifeq ($(uname_S),NONSTOP_KERNEL)
>> >         NO_MKDTEMP = YesPlease
>> >         OLD_ICONV = UnfortunatelyYes
>> > -       NO_REGEX = YesPlease
>> > +       NO_REGEX=NeedsStartEnd
>> >         NO_PTHREADS = UnfortunatelyYes
>> 
>> Style nit (probably not worth a re-roll): you lost the whitespace surrounding
>> '='
>
> I can fix this one in the next round of changes, or after this gets in, if that works, or signoff on this being fixed in place.

I've already tweaked this while queuing. i.e. no need to resend only to fix this one.

Thanks, both.