Re: Feature request: Add --no-edit to git tag command

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 4, 2019, 09:13 UTC
Message-ID: <xmqqo95mf80j.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190404015744.GF4409@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Wed, Apr 03, 2019 at 09:38:02AM -0500, Robert Dailey wrote:
>
>> Similar to git commit, it would be nice to have a --no-edit option for
>> git tag. Use case is when I force-recreate a tag:
>> 
>> $ git tag -af 1.0 123abc
>> 
>> An editor will be prompted with the previous annotated tag message. I
>> would like to add --no-edit to instruct it to use any previously
>> provided message and without prompting the editor:
>> 
>> $ git tag --no-edit -af 1.0 123abc
>
> Yeah, that sounds like a good idea.

I am not so sure this is a good idea, especially if the plan is to do this alone without necessary associated change to make things consistent.

The part that bothers me most is use of "-f". The mentalitly behind "-f" is "I am creating a new and tag that is totally unrelated to any existing tag, but since the command refuses to reuse the ref to point at my new tag, I am giving an '-f' to force (1) unpointing the existing unrelated tag and (2) pointing the enwly created tag with that tagname".

The proposed change still uses "-f" but wants to somehow take the tag message from the unrelated tag that happens to sit at the same place as the new tag wants to go. That breaks the mental model a big way.

If this were a new option that is spelled "--amend", I won't be complaining, though.