Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2019, 17:22 UTC
Message-ID: <xmqqo90zfu7r.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190808093732.GA12257@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote:
>
>> But a dash bug[*] causes it to instead expand to
>> 
>> 	/3456789...
>> 
>> The stream of symbols that makes up this function is hard for humans
>> to follow, too.  The complexity mostly comes from the repeated use of
>> the expression ${1#??} for the basename of the loose object.
>
> Yeah, both seem like good reasons to change this (and the patch looks
> good to me).

Good spottig.  Thanks.

Show 11 quoted lines

> +# Check whether the shell supports the "local" keyword. "local" is not
> +# POSIX-standard, but it is very widely supported by POSIX-compliant
> +# shells, and we rely on it within Git's test framework.
> +#
> +# If your shell fails this test, the results of other tests may be
> +# unreliable. You may wish to report the problem to the Git mailing
> +# list <git@vger.kernel.org>, as it could cause us to reconsider
> +# relying on "local".
>  test_expect_success 'verify that the running shell supports "local"' '
>  	x="notlocal" &&
>  	echo "local" >expected1 &&

Updated text reads well. Leaving the test in is still a very good idea.

Thanks.