Re: [PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2019, 01:24 UTC
Message-ID: <xmqqo8yt4aak.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191006233043.3516-1-e@80x24.org>

Eric Wong <e@80x24.org> writes:

Show 5 quoted lines

> v3 changes:
> - use __typeof__ to avoid invalid clang warning on uninitialized var
> - formatting fixes recommended by Stolee
> - add Reviewed-by for Stolee
> - add patch 20 to update docs to drop first member requirement

I just did

	git checkout ew/hashmap
	git checkout master...
	git am -s <mbox-with-these-patches
	git diff @{-1}

and all the differences between them I agree with (and needless to say, I looked at all the changes in the previous round).

Looks much nicer.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.