Re: [GSoC][PATCH 1/1] t1050: clean up checks for file existence

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2020, 17:50 UTC
Message-ID: <xmqqo8tq5x5t.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200222071335.27292-2-wasmus@zom.bi>

Rasmus Jonsson <wasmus@zom.bi> writes:

> Replace "test -f" with test_path_is_file, which gives more verbose
> and accurate output.

Does it? "test -f" is designed to be silent, while the helper function is designed to be verbose to help debugging the tests, but the accuracy of the latter simply rests on the former.

Also

> Subject: Re: [GSoC][PATCH 1/1] t1050: clean up checks for file existence

"test -f <path>" is not unclean. It just is that it is less helpful than using test_path_is_file.

	Subject: [PATCH] t1050: use test_path_is_file instead of "test -f"

	Use test_path_is_file instead of "test -f"; this will help
	when running the test with the "-v" option for debugging.

> Signed-off-by: Rasmus Jonsson <wasmus@zom.bi>