Re: [PATCH 5/8] builtin/clone: compute checkout metadata for clones

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 15, 2020, 19:30 UTC
Message-ID: <xmqqo8sxa00o.fsf@gitster.c.googlers.com>
In-Reply-To: <20200315103929.GH3122@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 13 quoted lines

> On Tue, Mar 10, 2020 at 06:20:43PM +0000, brian m. carlson wrote:
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index 1ad26f4d8c..00e5427ef1 100644
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -780,11 +780,12 @@ static int checkout(int submodule_progress)
>>  	if (!strcmp(head, "HEAD")) {
>>  		if (advice_detached_head)
>>  			detach_advice(oid_to_hex(&oid));
>> +		free(head);
>> +		head = NULL;
>
> Coccinelle suggests to use FREE_AND_NULL(head) instead.

Thanks; squashed to update 'pu'.