Re: [PATCH] builtin/receive-pack: use constant-time comparison for HMAC value

From

Junio C Hamano <gitster@pobox.com>

Date

Apr 22, 2020, 15:57 UTC

Message-ID

<xmqqo8rjjyxy.fsf@gitster.c.googlers.com>

In-Reply-To

<20200422102734.GA3063@szeder.dev>

Subject: receive-pack: compilation fix

Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/receive-pack.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 45e2dd2a65..66149777a0 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -505,7 +505,9 @@ static char *find_header(const char *msg, size_t len, const char *key,
 static int constant_memequal(const char *a, const char *b, size_t n)
 {
 	int res = 0;
-	for (size_t i = 0; i < n; i++)
+	size_t i;
+
+	for (i = 0; i < n; i++)
 		res |= a[i] ^ b[i];
 	return res;
 }

-- 
2.26.2-108-g048abe1751